fix(mysql): DATE_ADD for datetimes #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barakalon
commented
Oct 2, 2023
| @@ -9775,7 +9775,7 @@ JOIN "date_dim" AS "d1" | |||
| ON "catalog_sales"."cs_sold_date_sk" = "d1"."d_date_sk" | |||
| AND "d1"."d_week_seq" = "d2"."d_week_seq" | |||
| AND "d1"."d_year" = 2002 | |||
| AND "d3"."d_date" > CONCAT("d1"."d_date", INTERVAL '5' day) | |||
| AND "d3"."d_date" > "d1"."d_date" + INTERVAL '5' day | |||
There was a problem hiding this comment.
Seems like this change caught a bug.
georgesittas
reviewed
Oct 2, 2023
There was a problem hiding this comment.
Nice work @barakalon, these date/time optimizations look really interesting. I wonder if they are valid in all supported dialects though? Date/time stuff can vary wildly...
Left a few comments to consider.
|
Yeah, I also am unsure of all the different nuances of different dialects. |
georgesittas
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent logic I added for transpiling DATE_ADD in MySQL was wrong.
MySQL's DATE_ADD semantics are different than Hive's: https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-add
I'm not sure of a good way to handle this at the parser/generator level without a bunch of new TsOrDs* functions. So I added it to the optimizer for now.