Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: switch identifier normalization off using comments #2361

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

georgesittas
Copy link
Collaborator

No description provided.

@georgesittas georgesittas requested a review from tobymao October 2, 2023 22:05
@tobymao
Copy link
Owner

tobymao commented Oct 2, 2023

not sure if this change is correct, i think it should just be done in the optimizer, then you won't have to check the parent right?

@georgesittas
Copy link
Collaborator Author

Not sure what you mean, why wouldn't we need to check the parent? The reasoning for doing that here is that a comment next to an identifier may be attached to a higher-level AST node like a Column or a Table, so we need to make sure to check if that's the case.

@tobymao
Copy link
Owner

tobymao commented Oct 2, 2023

we normalize identifiers through optimizer/normalize_identifiers. we call transform, simply check the meta to stop traversal into the node. so when the column is checked, we stopped traversing, it will simplify this change

@georgesittas
Copy link
Collaborator Author

we normalize identifiers through optimizer/normalize_identifiers. we call transform, simply check the meta to stop traversal into the node. so when the column is checked, we stopped traversing, it will simplify this change

Done

@georgesittas georgesittas merged commit 55e2d15 into main Oct 2, 2023
@georgesittas georgesittas deleted the jo/force_normalization_off branch October 2, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants