This repository has been archived by the owner on Aug 19, 2019. It is now read-only.
Fix build by checking in dist/ #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking in the build is an antipattern. It is also the easiest way to work around the deficiencies in the react-infinite-calendar build process.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per clauderic#48 (comment) , the only easy way to solve build issues (the fact that dist/ doesn't exist, b/c devDependencies aren't installed by npm when it pulls this package elsewhere, so the pkg cannot be built & is empty mostly) is to just always check in to git a complete copy of dist/.
We're not planning to change react-infinite-calendar that much. I think this is an acceptable compromise.
Ugly? Yes, but I wrote in 6 foot tall letters over the README so you can't forget.
Additionally, Babel's got some quirky weirdness going on atm that was making my local builds fail (cannot find caniuse-db et al.)
Someone figured out the issue: Fyrd/caniuse#3073 (comment)
Someone else's fix: https://github.com/acolchado/spur-ioc/commit/7c5be0c88ea2efb52a6f670b931469ea9f49263d
Reproduced here. Basically fixing babel-plugin-transform-regenerator to exactly version 6.16.1, until the Babel community manages to work out what the hell happened (ETA: weeks).