Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passive review prompt #1295

Closed
tcrammond opened this issue Feb 11, 2019 · 2 comments · Fixed by #1413
Closed

Passive review prompt #1295

tcrammond opened this issue Feb 11, 2019 · 2 comments · Fixed by #1413
Assignees
@shantanuraj
Labels
estimate: s Small released

Comments

@tcrammond
Copy link
Contributor

tcrammond commented Feb 11, 2019 •
edited
Loading

A passive prompt somewhere inside the new settings page for very active users, suggesting to leave a review for the extension. This way it will only be seen if the settings page is being visited. It will not involve any kind of notification.

The prompt can be dismissed, e.g. "Never ask again".

Plans:

  • Detect "Active user" in the settings page. We'll probably need to start ticking a storage value for active days, or entries created in button etc.
  • Show the passive prompt. Perhaps it can go in the footer? It's even less intrusive there than in the main body of any settings tabs.
  • The prompt must open the correct web extension store for the browser being used.
    • If it is opened, never show it again.
    • If it is dismissed, never show it again.
  • If user uses the Reset all settings feature, DO NOT reset the sync storage value for this feature.
@tcrammond tcrammond added the needs more info An item that is missing information or requires further discussion. label Feb 11, 2019
@tcrammond tcrammond added the estimate: s Small label Mar 14, 2019
@tcrammond tcrammond removed the needs more info An item that is missing information or requires further discussion. label Apr 30, 2019
@shantanuraj
Copy link
Contributor

Store interaction with the button in sync storage
Do not delete on reset all settings click

@shantanuraj shantanuraj self-assigned this May 8, 2019
@shantanuraj shantanuraj mentioned this issue May 15, 2019
Merged
shantanuraj added a commit that referenced this issue May 21, 2019
@shantanuraj
feat(settings): Show review prompt to active users
f9bb8c3 
Closes #1295
shantanuraj added a commit that referenced this issue May 21, 2019
@shantanuraj
feat(settings): Show review prompt to active users
8d1e9c3 
Closes #1295
shantanuraj added a commit that referenced this issue May 21, 2019
@shantanuraj
feat(settings): Show review prompt to active users
8c7664f 
Closes #1295
shantanuraj added a commit that referenced this issue May 21, 2019
@shantanuraj
feat(settings): Show review prompt to active users
6003a71 
Closes #1295
shantanuraj added a commit that referenced this issue May 21, 2019
@shantanuraj
feat(settings): Show review prompt to active users
c61f3c5 
Closes #1295
toggl-button-bot added a commit that referenced this issue May 21, 2019
@toggl-button-bot
chore(release): 1.36.0 [skip ci]
e1dcb59 
# [1.36.0](1.35.6...1.36.0) (2019-05-21)

### Features

* **settings:** Show review prompt to active users ([c61f3c5](c61f3c5)), closes [#1295](#1295)
@toggl-button-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shantanuraj shantanuraj

Labels
estimate: s Small released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add passive review prompt toggl/track-extension
3 participants
@shantanuraj @tcrammond @toggl-button-bot