Skip to content

Commit

Permalink
feat(settings): Show review prompt to active users
Browse files Browse the repository at this point in the history
Closes #1295
  • Loading branch information
shantanuraj committed May 21, 2019
1 parent b63cf10 commit 6003a71
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
4 changes: 4 additions & 0 deletions src/scripts/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -193,3 +193,7 @@ declare module Toggl {
type TogglButton = {
$user: Toggl.User | null;
}

type TogglDB = {
get<T>(key: string): Promise<T | null>;
}
11 changes: 9 additions & 2 deletions src/scripts/lib/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ export function getStoreLink (isFirefox = false) {
return 'https://chrome.google.com/webstore/detail/toggl-button-productivity/oejgccbfbmkkpaidnkphaiaecficdnfn';
}

export async function isActiveUser () {
return true;
/**
* Number of life-time entries the user must have tracked
* with Toggl Button to be considered an active user
*/
const ACTIVE_USER_TRESHOLD = 30;

export async function isActiveUser (db: TogglDB) {
const timeEntriesTracked = await db.get<number>('timeEntriesTracked') || 0;
return (timeEntriesTracked >= ACTIVE_USER_TRESHOLD);
}
2 changes: 1 addition & 1 deletion src/scripts/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,7 @@ document.addEventListener('DOMContentLoaded', async function (e) {

Settings.loadSitesIntoList();

const shouldShowReviewPrompt = await isActiveUser();
const shouldShowReviewPrompt = await isActiveUser(db);
if (shouldShowReviewPrompt) {
showReviewPrompt();
}
Expand Down

0 comments on commit 6003a71

Please sign in to comment.