fix(rememberthemilk): Fix errors and conform to styleguide in Remembe…

…rTheMilk
toggl · May 24, 2019 · f269344 · f269344
1 parent cb5662c
commit f269344
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/src/scripts/content/rememberthemilk.js b/src/scripts/content/rememberthemilk.js
@@ -22,21 +22,20 @@ togglbutton.render(
       return p.textContent;
     };
 
-    // Create and return toggl button's instance.
-    const createTogglButton = function () {
-      return togglbutton.createTimerLink({
+    const task = elem
+      .querySelector(
+        "div[role='listbox'] [role='option'] span[style*='user-select: text']"
+      );
+
+    if (task) {
+      const link = togglbutton.createTimerLink({
         className: 'rememberthemilk',
         description: getDescription,
         projectName: getProject,
         buttonType: 'minimal'
       });
-    };
 
-    // Inject toggl button to each task.
-    elem
-      .querySelector(
-        "div[role='listbox'] [role='option'] span[style*='user-select: text']"
-      )
-      .parentElement.appendChild(createTogglButton());
+      task.parentElement.appendChild(link);
+    }
   }
 );
diff --git a/src/styles/style.css b/src/styles/style.css
@@ -886,6 +886,13 @@ li > .toggl-button.phabricator {
   margin-left: 5px;
   position: absolute;
 }
+.toggl-button.rememberthemilk:not(.active) {
+  display: none !important;
+}
+
+*:hover > .toggl-button.rememberthemilk {
+  display: inline-block !important;
+}
 
 /********* FRESHDESK *********/
 .toggl-button.freshdesk {