fix(notion): Add extracting description from breadcrumbs as a fallback #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EternallLight
force-pushed
the
2068/notion-button-issue
branch
from
7d93a10 to
1d44287
Compare
tiberiusuciu
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What does this PR do?
The root cause of the issue was in missing
titleattribute on the button. The title is set during the TB initalization based on the description derived from the page content.In Notion description is extracted from the page main section. There are cases where Toggl Button renders before the main section and it cannot get the description during the initialization.
The same title is available in the breadcrumbs that are rendered along with the Toggl Button is the top bar. As a fallback, I added extracting the description from the breadcrumbs last text value.
🐛 Recommendations for testing
Go to this page and run the timer.
Once the popdown is hidden, the button text should be "Stop timer".
📝 Links to relevant issues or information
Closes #2068