Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(youtrack): add correct selector #2354

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fix(youtrack): add correct selector #2354

merged 3 commits into from
Jan 7, 2025

Conversation

askides
Copy link
Contributor

@askides askides commented Nov 22, 2024

Please remember the Contributing Guidelines ❤️

🌟 What does this PR do?

This PR adds a fix for the YouTrack single page issue (which is not working).

First commit is formatting.

image

🐛 Recommendations for testing

All changes should be tested across Chrome and Firefox.

  1. Go to YouTrack
  2. Open an issue
  3. You should see the button (and optionally if there's a project the project will match).

@askides askides requested review from izontm and with-shrey November 22, 2024 12:38
@askides askides self-assigned this Nov 22, 2024
src/origins.js Outdated
@@ -711,6 +711,11 @@ export default {
name: 'YouTrack',
file: 'youtrack.js'
},
'youtrack.com': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate entry
.cloud is the correct one

Screenshot 2024-11-25 at 3 47 41 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right!

@askides askides force-pushed the fix/youtrack-issues branch from b2c0e2c to ce4ec08 Compare November 25, 2024 10:30
@askides askides requested a review from with-shrey November 25, 2024 10:32
@askides askides merged commit 7ecc77a into master Jan 7, 2025
1 check passed
@askides askides deleted the fix/youtrack-issues branch January 7, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants