Skip to content

Commit

Permalink
deps: require curl < 0.4.34 to fix MSRV
Browse files Browse the repository at this point in the history
Builds are failing on unrelated pull requests (e.g., #326) because the
`curl` crate has pushed a new version that depends on Rust 1.40, while
our CI tests against 1.39. We could probably bump to require 1.40 as
well, especially since we want to use the same `#[non_exhaustive]`
attribute, per #43. But a minimal change to unblock development and keep
the current minimum stable Rust version is to just pin `curl < 0.4.34`.

Test Plan:
Running `cargo +1.39.0 test --workspace --all-targets` passes on my
Linux machine.

wchargin-branch: deps-curl-pre-0.4.34
wchargin-source: c2910530bd49190605176c9f69f3aff1863443c2
  • Loading branch information
wchargin authored and danburkert committed Nov 8, 2020
1 parent 4ded4a9 commit 6c8c69e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion protobuf/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ prost-types = { path = "../prost-types" }
[build-dependencies]
anyhow = "1"
cfg-if = "0.1"
curl = "0.4"
# curl 0.4.34 requires Rust 1.40 or higher:
# https://github.com/alexcrichton/curl-rust/pull/356/files#r498918694
curl = "0.4, < 0.4.34"
flate2 = "1.0"
prost-build = { path = "../prost-build" }
tar = "0.4"
Expand Down

0 comments on commit 6c8c69e

Please sign in to comment.