Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump 0.1 versions for latest changes #1240

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Bump 0.1 versions for latest changes #1240

merged 3 commits into from
Jul 3, 2019

Conversation

jonhoo
Copy link
Contributor

@jonhoo jonhoo commented Jul 2, 2019

This bumps the minor version for threadpool and executor for #1155, and tokio itself for #1223.

@jonhoo jonhoo requested a review from carllerche July 2, 2019 19:38
@jonhoo
Copy link
Contributor Author

jonhoo commented Jul 2, 2019

Looks like CI fails when I bump the version requirement. Not sure how we handle that? Does this need to be done in three steps?

@carllerche
Copy link
Member

Ah yes... commits for releases need to include [ci-release] somewhere in the message.

@jonhoo
Copy link
Contributor Author

jonhoo commented Jul 3, 2019

@carllerche done!

carllerche
carllerche approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 super helpful to put this together.

@carllerche carllerche merged commit b4cb322 into v0.1.x Jul 3, 2019
@carllerche carllerche deleted the jonhoo/bump-for-tracing branch July 8, 2019 17:09
@dekellum dekellum mentioned this pull request Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonhoo @carllerche @LucioFranco