Implement "split_mut" for TcpStream #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Thanks 👍 looks good to me. I like this strategy.
I have some bikeshed level thoughts, but I just tracked them in #1209.
I do think that split_mut should become the "primary" split fn. I don't have a great name for the existing split (maybe into_split?). Thoughts?
|
It just needs to have a |
|
Great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See here for a longer motivation:
rust-lang/futures-rs#1727
The TLDR is that I think a "split_mut" method on types implementing traits like
AsyncReadcould open up the possibility of the AsyncRead/AsyncWrite trait methods returning "normal-ish" futures, and eventually allow the methods on these traits to be implemented using async functionsNote: this is more useful than it might appear, because the Pin API allows the ownership of a TcpStream, and non-static borrows of that TcpStream to be bundled into a future without any lifetime bounds of its own.