v0.1.x lint fix, MSRV 1.28.0 updates #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recent rust nightly started warning that not using `dyn` was deprecated. This requires MSRV 1.27.0+.
Since tokio-macros specifies an edition=2018, we would otherwise require MSRV 1.31.0 to build/test it. And tokio-macros isn't used with tokio 0.1.x.
Since 0.1.5-6 is now a edition=2018 crate, which has effective MSRV 1.31.0.
tempfile 3.1.0 pulls in rand 0.7.0 and is MSRV 1.32.0
flate2 1.0.10-11 have MSRV 1.34.0. github refs: rust-lang/flate2-rs#207
In particular because it pulls in old rand duplicates. Replace use with tempfile::tempdir() which has been available since tempfile 3.0.0. backport-of: tokio-rs#1312
In particular to fix the build for new stable 1.37.0 and otherwise reduce warning verbosity.
|
How about reviewing and considering merging this before some other dependency changes, @LucioFranco ? |
LucioFranco
reviewed
Aug 15, 2019
LucioFranco
approved these changes
Aug 15, 2019
This was referenced Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for a more conservative subset of #1348 proposal, per discussion with @LucioFranco.
Note as with 81a898f and 6c4e5b4, rust-lang/flate2-rs#207 that MSRV bumps in patch releases are an ongoing nuisance.