sync: remove RwLockWriteGuard::map and RwLockWriteGuard::try_map #3345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobz
approved these changes
Dec 25, 2020
carllerche
approved these changes
Dec 25, 2020
|
If we instead solve this soundness issue by changing the return type of |
Darksonn
changed the title
|
We have decided to remove the We just don't have the review-bandwidth to do this in one go on the 25th of December. |
Darksonn
force-pushed
the
remove-downgrade
branch
from
3037ff1 to
42845d2
Compare
Darksonn
changed the title
udoprog
approved these changes
Dec 25, 2020
This was referenced Dec 25, 2020
carllerche
added
the
I-unsound 💥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a soundness hole. This is a breaking change, but breaking changes are allowed under our semver policy when they are required to fix a soundness hole. (See this RFC for more).
Note that we have chosen not to do a deprecation cycle or similar because Tokio 1.0.0 was released two days ago, and therefore it should not impact many people.
Closes: #3344