-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deadlock after updating to tracing-core 0.1.31 #2635
Comments
I don't know why this is occurring right now, but is this where rustc sets up As an additional note, |
Yes, you're looking in the right place. |
Well, this is definitely a bug! We'll look into it. |
I just stumbled across this. Any progress? |
I just went throught the stacktrace and it seems like a deadlock inside It uses a lock when you try to log something, but it internally used So I guess using the fmt layer from Proper fix will probably have to be done in |
@nnethercote Could you try updating This should get rid of the deadlock but note that some output logged inside the |
I'm going to close this; this is an issue in tracing-tree. |
Sorry, I should have been clearer. When I said that I "stumbled across this" I meant that I saw this line in rustc: but I haven't actually encountered the bug in action myself. @Nilstrieb, are you able to try |
bump tracing Unpins `tracing`: linked issue looks fixed, tokio-rs/tracing#2635 referencing davidbarsky/tracing-tree#82 Perf run please, as changelog says about improvements https://github.com/tokio-rs/tracing/blob/tracing-0.1.40/tracing/CHANGELOG.md https://github.com/tokio-rs/tracing/blob/tracing-core-0.1.32/tracing-core/CHANGELOG.md
Version
I've narrowed the problem down to
tracing-core 0.1.31
, but here are all the tracing versions in tree after runningcargo update
, which reproduces the problem.all the tracings
This is after
cargo update
.Platform
x86_64-unknown-linux-gnu in CI and aarch64-unknown-linux-gnu on my computer were both able to reproduce the deadlock, I haven't tried anything else.
Crates
tracing-core
Description
I updated all crates, which included tracing. After updating (which I've narrowed down to just bumping
tracing-core
from 0.1.30 to 0.1.31), the program (rustc) is stuck in a deadlock when debug logs are enabled. The deadlock happens after quite some logs are already emitted. rustc is single threaded, but all work happens on a second spawned thread, which deadlocks when locking a mutex.gdb backtrace of that thread
I encountered this in rust-lang/rust#113046
How to reproduce:
./x setup compiler && x test tests/ui/rustc-rust-log.rs
rustup toolchain link stage1 build/host/stage1
and thenrustc +stage1
The text was updated successfully, but these errors were encountered: