Presenter view context #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self isn't a view context in ActionView::TestCase
Better tests
Not sure what this was doing before..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the presenter's public methods to the view context used when rendering the component, instead of just setting the local variables when rendering. This allows for use of any method, a la 'helper methods', which is a lot more flexible than a hash of variables.
It does this by adding delegators on the view context for each of the presenter's public methods. To facilitate this it also defines readers for the properties set against the component class, which is useful when defining other methods for the component.
I think this works a lot better than my previous implementation, but I'm very open to any comments!