Change class names #137
Closed
Change class names #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommilligan
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Thank you, this looks excellent. Agree that changing the classnames and bumping the assets version is exactly the right way to go about this.
There is some minor additional diff in the style files, but I've been meaning to add a linter for them for a while so this is a good excuse to do that (see #138). I'm happy to rebase your changes once that's in, no additional work required from you!
compile_assets/scss/admonition.scss
Outdated
| @@ -62,11 +62,12 @@ $admonitions: ( | |||
| // Admonition variables | |||
| :root { | |||
| @each $names, $props in $admonitions { | |||
| --md-admonition-icon--#{nth($names, 1)}: | |||
There was a problem hiding this comment.
There appears to be some unrelated diff at and below this line
|
Github did something I didn't expect when I rebased this - moved to #139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdBook 0.4.35 introduces a way of creating warning blocks achieved by having a div with a
warningclass. This is a conflict with mdbook-admonish which useswarningfor the warning admonitions. To avoid that, this pull request prefixes each admonition class name withadmonish-.Reference: rust-lang/mdBook#2187