Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new SelectTerms #1584

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Implement new SelectTerms #1584

merged 9 commits into from
Dec 11, 2024
+81 −117

Conversation

iansvo
Copy link
Collaborator

@iansvo iansvo commented Dec 9, 2024 •
edited
Loading

@iansvo iansvo requested a review from tomusborne December 9, 2024 21:55
@iansvo iansvo self-assigned this Dec 9, 2024
@iansvo iansvo changed the title Update Implement new SelectTerms Dec 9, 2024
@tomusborne
Copy link
Owner

@iansvo Let's revert the changes here that remove source as a valid supports for the term meta.

@iansvo
Copy link
Collaborator Author

iansvo commented Dec 10, 2024

I've restored the source functionality and confirm the "current term" option works as expected in elements.

@iansvo iansvo added feature Features, refactoring, enhancements, improvements Block: Query labels Dec 10, 2024
@tomusborne
Copy link
Owner

@iansvo Only issue I'm seeing here is that I'm unable to clear the Select Terms select using the x icon.

@tomusborne tomusborne merged commit fab5965 into release/2.0.0 Dec 11, 2024
9 checks passed
@tomusborne tomusborne deleted the tweak/query-inspector-controls branch December 11, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusborne tomusborne Awaiting requested review from tomusborne

Assignees

@iansvo iansvo

Labels
Block: Query feature Features, refactoring, enhancements, improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iansvo @tomusborne