Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Bug when using button as a RichText tag #1585

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix: Bug when using button as a RichText tag #1585

merged 1 commit into from
Dec 10, 2024

Conversation

tomusborne
Copy link
Owner

closes #1524

@tomusborne tomusborne added the bug Bugs, unexpected and weird behaviors label Dec 10, 2024
@tomusborne tomusborne added this to the 2.0.0 milestone Dec 10, 2024
@tomusborne tomusborne requested a review from iansvo December 10, 2024 01:35
@tomusborne tomusborne linked an issue Dec 10, 2024 that may be closed by this pull request
GB 2.0.0 Beta.2 can't type space in Text block with button tag #1524
Closed
iansvo
iansvo approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@iansvo iansvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for the button variant and text block, nice solve!

@iansvo iansvo merged commit 2cf88ba into release/2.0.0 Dec 10, 2024
9 checks passed
@iansvo iansvo deleted the fix/button-richtext-bug branch December 10, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansvo iansvo iansvo approved these changes

Assignees
No one assigned
Labels
bug Bugs, unexpected and weird behaviors
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

GB 2.0.0 Beta.2 can't type space in Text block with button tag
2 participants
@tomusborne @iansvo