Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements preview support, Query improvements #1596

Merged
merged 9 commits into from
Dec 17, 2024

Conversation

iansvo
Copy link
Collaborator

@iansvo iansvo commented Dec 16, 2024

Required PRs

New

Improved

  • SelectPostType now supports single or multiple selection.

Fixed

  • Post per page editor cap is now correctly enforced.
  • Updated Looper renderer to fix error that causes InspectorControls to not render if the Query has no items found.

@iansvo iansvo requested a review from tomusborne December 16, 2024 14:48
@iansvo iansvo self-assigned this Dec 16, 2024
@iansvo iansvo added feature Features, refactoring, enhancements, improvements Dynamic Tags Block: Query labels Dec 16, 2024
@iansvo iansvo changed the title Tweak/dynamic tags filter replace tags Elements preview support, Query improvements Dec 16, 2024
@tomusborne
Copy link
Owner

@iansvo Are we hoping to get this into the rc tomorrow? Or do we want to do another beta?

My only concern is the changing of params (noted above).

We need to be careful when changing params, especially filter params. One user got a fatal error when updating to latest Pro while still having older Free, as the number of args in the query filter was no longer correct (just as an example).

@iansvo
Copy link
Collaborator Author

iansvo commented Dec 16, 2024

Overall this seems to work great, we had testing done which @diggeddy noted out, all seems pretty solid. There's a small issue with post meta queries which I'd like to resolve in the pro PR before we merge this, should be very easy to do.

@tomusborne tomusborne merged commit b98717c into release/2.0.0 Dec 17, 2024
9 checks passed
@tomusborne tomusborne deleted the tweak/dynamic-tags-filter-replaceTags branch December 17, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block: Query Dynamic Tags feature Features, refactoring, enhancements, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants