-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elements preview support, Query improvements #1596
Elements preview support, Query improvements #1596
Conversation
@iansvo Are we hoping to get this into the rc tomorrow? Or do we want to do another beta? My only concern is the changing of params (noted above). We need to be careful when changing params, especially filter params. One user got a fatal error when updating to latest Pro while still having older Free, as the number of args in the query filter was no longer correct (just as an example). |
Overall this seems to work great, we had testing done which @diggeddy noted out, all seems pretty solid. There's a small issue with post meta queries which I'd like to resolve in the pro PR before we merge this, should be very easy to do. |
Required PRs
New
Improved
Fixed