Fix: Editor width when using an iframe #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansvo
reviewed
Oct 24, 2024
| @@ -40,12 +40,13 @@ function getContentWidth( layout, contentContainer = '' ) { | |||
| const ContentWidth = () => { | |||
| const [ sidebarLayout, setSidebarLayout ] = useState( generatepressBlockEditor.sidebarLayout ); | |||
| const [ fullWidth, setFullWidth ] = useState( generatepressBlockEditor.contentAreaType ); | |||
| const editorWrapperStyles = document.querySelector( '.editor-styles-wrapper' )?.style; | |||
| const queryDocument = document.querySelector( 'iframe[name="editor-canvas"]' )?.contentDocument || document; | |||
| const editorWrapperStyles = queryDocument.querySelector( '.editor-styles-wrapper' )?.style; | |||
|
|
|||
| // We use editorWrapperStyles to update the content width when changing devices or code editor to visual editor. | |||
| // See https://github.com/tomusborne/generatepress/issues/493. | |||
| useEffect( () => { | |||
There was a problem hiding this comment.
We'll want to test this, but we may end up wanting to go with useLayoutEffect in case that query fails because the DOM is being updated.
There was a problem hiding this comment.
@iansvo Just updated this. It now checks whether we're dealing with the iframe or code editor. This makes sure the content width stays applied even when these events happen and the editor changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where our editor width value doesn't apply to the editor when it's using an iframe.