Add benchmark comparing join of gen expression vs join of list comp #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically generator expressions are supposed to be more performance, but apparently str.join converts an iterable arg to a list anyway, if its not yet, so generator expressions add an overhead for conversion.
https://stackoverflow.com/questions/37782066/list-vs-generator-comprehension-speed-with-join-function
Current source code:
https://github.com/python/cpython/blob/main/Objects/unicodeobject.c#L9375
In my scalene tests, performance is better for the list comprehension version. This benchmark should show that as well, though I'm not sure if I've formatted it correctly.