Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the install command for the new Vite frontend #26

Closed
tonysm opened this issue Jun 30, 2022 · 3 comments
Closed

Fix the install command for the new Vite frontend #26

tonysm opened this issue Jun 30, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@tonysm
Copy link
Owner

tonysm commented Jun 30, 2022

Looks like the install command doesn't work with the new Vite frontend setup from Laravel. Needs fixing.

@tonysm tonysm added the bug Something isn't working label Jun 30, 2022
@tonysm
Copy link
Owner Author

tonysm commented Jun 30, 2022

I went through the broken setup pretty fast, but from what I could see:

  1. Remove the CSS import from our trix-webpack.js (file) - btw, the naming needs to change, I guess
  2. Add note about adding the @import "./_trix.css" to the main resources/css/app.css file - maybe Laravel's default scaffolding could change to use @import instead of @tailwind (I'll see if that can be contributed) Edit: prepend the @import './_trix.css'; line to the main CSS file (should work just fine)
  3. Find a way to append the new <x-rich-text-trix-styles /> to the templates' head (for both Breeze and Jetstream)

@tonysm
Copy link
Owner Author

tonysm commented Jun 30, 2022

Sent PRs to Breeze and Jetstream to see if we can switch back to using @import instead of @tailwind Edit: no need to switch everything to @import, we can just prepend the line to the main file and the @tailwind and the @import should work just fine.

@tonysm
Copy link
Owner Author

tonysm commented Jul 3, 2022

@tonysm tonysm closed this as completed Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant