Use @import instead of @tailwind #1079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jessarcher @timacdonald can you review this and mark as ready for review once you have done so? |
|
Closing because of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also made this change proposal in Breeze: laravel/breeze#165
This was changed in this PR: #1060
But I think packages can benefit more from using the postcss-import style in the main TailwindCSS setup.
In the Rich Text Laravel package, for instance, I dump some CSS file to the
resources/css/folder and in order to be able to add the@import "./_trix.css";line to the main CSS file, I'd need to swap the entire file for a version of it using@import, which can be problematic since developers could have added more things to it and all.If this was webpack, we would have to install the
postcss-importplugin and require it ourselves, but I've tested this with the new Vite setup and it looks like just works. Not sure if there's anything to do.