Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topomap missing boost dependency #1033

Closed
petersteneteg opened this issue May 31, 2024 · 3 comments
Closed

Topomap missing boost dependency #1033

petersteneteg opened this issue May 31, 2024 · 3 comments

Comments

@petersteneteg
Copy link
Contributor

Describe the bug

When Qhull is not found or if TTK_ENABLE_QHULL is false
the TopoMap module will use boost, but the CMakeList file does not link boost.

Adding this at the end will fix the issue

if(NOT TTK_ENABLE_QHULL OR NOT Qhull_FOUND)
  target_link_libraries(topoMap PUBLIC Boost::boost)
endif()
@julien-tierny
Copy link
Collaborator

Thanks a lot for the heads up.
TopoMap built fine under linux without this patch and our windows CI didn't catch up the issue (as it installed QHull).
The PR #1034 should address that.
Thanks for letting me know if #1034 is OK for you.
Best,

@petersteneteg
Copy link
Contributor Author

Great! that's perfect.
Thank you!

@julien-tierny
Copy link
Collaborator

thanks a lot for the hot fix!

julien-tierny added a commit that referenced this issue May 31, 2024
Fix topoMap boost link issue (windows, #1033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants