Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adjusting dates due to local timezone #102

Merged
merged 1 commit into from
Sep 22, 2014
Merged

Avoid adjusting dates due to local timezone #102

merged 1 commit into from
Sep 22, 2014

Conversation

dustinfarris
Copy link
Collaborator

It seems that Date.toISOString applies a transformation to the Date object based on the user's local timezone. This can often lead to unwanted data alterations when a date is serialized. See #100.

/cc @benkonrath

@benkonrath
Copy link

Yep, this fixes the problem. Thanks!

@benkonrath
Copy link

I have the same error from Travis in #101 so I'm not sure what's going on there.

@dustinfarris
Copy link
Collaborator Author

yeah i'm looking at that now. for some reason karma isn't running. might be related to f03d057

@dustinfarris
Copy link
Collaborator Author

@benkonrath travis is fixed. feel free to rebase.

dustinfarris pushed a commit that referenced this pull request Sep 22, 2014
Avoid adjusting dates due to local timezone
@dustinfarris dustinfarris merged commit 3636483 into toranb:master Sep 22, 2014
@dustinfarris dustinfarris deleted the fix-date-test branch September 22, 2014 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants