gen: Use the asyncio task runner for native coroutines #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a warning logged at GC time.
bdarnell
force-pushed
the
asyncio-task-runner
branch
from
06d5b0c to
91a2e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coroutines using
await/yield fromare more tightly coupled than coroutines usingyield; they must all share the same coroutine. The asyncio task runner publishes some non-local state that common libraries rely on, so these libraries could not be used in native coroutines that were started by tornado (aio-libs/aiohttp#877). Address this by using the asyncio task runner everywhere.