alternative to fixed paths #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually my question on OP_strex was answered here - if you are curious: |
|
Yes, unfortunately |
toshipiazza
reviewed
Apr 10, 2018
| set(DrMemoryFramework_DIR /home/piazzt/install/exports32/drmf) | ||
| ENDIF() |
There was a problem hiding this comment.
Feel free to remove the hardcoded DynamoRIO_DIR and DrMemoryFramework_DIR paths completely. I don't need them, they were mainly helpful for me when I was just starting out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fix to provide an alternative to the hardcoded paths.
small question - on ARM32/AARCHXX dynamorio forever loops for me when I insert instrumentations around OP_strex. did you notice the same issue in drtaint? (this is not a bug I encountered in drtaint but in my own experiments)