Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Kotlin Java version to 8 #114

Merged
merged 15 commits into from
Aug 20, 2024
Merged

Updating Kotlin Java version to 8 #114

merged 15 commits into from
Aug 20, 2024

Conversation

faogustavo
Copy link
Contributor

Fixes: #113

@faogustavo faogustavo force-pushed the gv/fixing-jvm-version branch from 29d24c9 to 6ddd8bc Compare August 7, 2024 14:30
@faogustavo faogustavo requested a review from kpgalligan August 7, 2024 14:31
findjigar
findjigar approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@findjigar findjigar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is failing with nodejs failure. Maybe we would need to update the version. Please fix it before merging.

@samhill303 samhill303 merged commit 457b645 into main Aug 20, 2024
1 check passed
@samhill303 samhill303 deleted the gv/fixing-jvm-version branch August 20, 2024 14:15
@faogustavo faogustavo mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findjigar findjigar findjigar approved these changes

@kpgalligan kpgalligan Awaiting requested review from kpgalligan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java 8 Compat
4 participants
@faogustavo @findjigar @samhill303 @kpgalligan