Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libffi-sys: arch: add constants for the MIPS family #87

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

chenx97
Copy link
Contributor

@chenx97 chenx97 commented Dec 4, 2023

Fixes #67.

@chenx97
Copy link
Contributor Author

chenx97 commented Dec 4, 2023

This architecture family has known QEMU support, but has been demoted to tier-3. Should I add it to the test matrix? We can use cargo +nightly -Zbuild-std if you want to automatically test them.

@chenx97 chenx97 force-pushed the libffi-sys/arch-mips-support branch from e53ac0f to 361b544 Compare December 5, 2023 05:09
@chenx97 chenx97 force-pushed the libffi-sys/arch-mips-support branch from 361b544 to 6e51906 Compare December 7, 2023 02:52
@chenx97
Copy link
Contributor Author

chenx97 commented Dec 7, 2023

@yorickpeterse would you mind taking a look at this patch?

@chenx97
Copy link
Contributor Author

chenx97 commented Dec 7, 2023

the heck? I locally tried both ubuntu 22.04 and debian bookworm, and s390x successfully passed the tests.

# export CARGO_TARGET_S390X_UNKNOWN_LINUX_GNU_LINKER=s390x-linux-gnu-gcc
# export CARGO_TARGET_S390X_UNKNOWN_LINUX_GNU_RUNNER='qemu-s390x -L /usr/s390x-linux-gnu'
# cargo +1.48.0 test --no-default-features --target=s390x-unknown-linux-gnu
   Compiling libc v0.2.150
   Compiling cc v1.0.83
   Compiling libffi-sys v2.3.0 (/ffirs/libffi-sys-rs)
   Compiling libffi v3.2.0 (/ffirs/libffi-rs)
    Finished test [unoptimized + debuginfo] target(s) in 13.91s
     Running /ffirs/target/s390x-unknown-linux-gnu/debug/deps/libffi-ee9f2b15a895b394

running 12 tests
test middle::test::call ... ok
test high::test::new_mut ... ok
test high::test::new_with_cif_mut ... ok
test high::test::new_with_cif ... ok
test high::test::new ... ok
test middle::test::clone_cif ... ok
test middle::test::closure ... ok
test middle::test::rust_lambda ... ok
test middle::types::test::clone_u64 ... ok
test middle::types::test::clone_struct ... ok
test middle::types::test::create_struct ... ok
test middle::types::test::create_u64 ... ok

test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Debugging suggestions would be appreciated.

@yorickpeterse yorickpeterse merged commit d0704d6 into tov:master Dec 7, 2023
62 checks passed
@yorickpeterse
Copy link
Collaborator

@chenx97 The failures are random so it's fine. Thanks for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support for mips and mips64
2 participants