Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tower-retry to std::future #326

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Update tower-retry to std::future #326

merged 3 commits into from
Sep 9, 2019

Conversation

jonhoo
Copy link
Collaborator

@jonhoo jonhoo commented Sep 9, 2019

No description provided.

@jonhoo jonhoo requested a review from LucioFranco September 9, 2019 16:39
tower-retry/src/lib.rs Outdated Show resolved Hide resolved
tower-retry/src/policy.rs Outdated Show resolved Hide resolved
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tower-retry/src/policy.rs Outdated Show resolved Hide resolved
@jonhoo jonhoo requested a review from LucioFranco September 9, 2019 19:01
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 👍

@jonhoo jonhoo merged commit 4f71951 into v0.3.x Sep 9, 2019
use tower_service::Service;

// NOTE: this is the trait generated for Ready::project() by pin-project.
// We need it here to be able to go "through" Ready to &mut Service without adding Unpin bounds.
use crate::__RetryProjectionTrait;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed taiki-e/pin-project#80 to resolve this.

@jonhoo jonhoo deleted the jonhoo/update-retry branch September 10, 2019 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants