Update the rest of the crates and upgrade ready cache to `std::f… #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
changed the title
std::future::Future
|
I'd appreciate if we could get a review of this today, so I can finish up the tonic work :) <3 |
LucioFranco
changed the title
std::future::Future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the rest of the crates and also converts
tower-ready-cachetostd::future::Future.I tried to somewhat break up the commits into pieces that should be reviewed together. Mostly, around the ready cache upgrade.
After this PR I plan to do a pass of the crates to clean things up.