log: don't enable this feature by default #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, tracing/log is a non-additive feature (tokio-rs/tracing#1793), so enabling it is a bit radioactive.
davidpdrsn
approved these changes
Apr 13, 2022
hawkw
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
I think that most people using Tower are probably also using tracing at this point, so I'm fine with removing the log support.
However, there's definitely an argument that this should be considered a breaking change. Although it shouldn't cause compilation to break, it does mean that log records from tower may suddenly disappear for any users who are (a) using log and (b) not enabling the tracing/log feature themselves. On the other hand...I don't actually care very much. I just thought this was worth bringing up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, tracing/log is a non-additive feature (tokio-rs/tracing#1793), so enabling it is a bit radioactive.