fix: Correct CTR calculation in InsightStats component #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CTR calculation was incorrectly summing up individual CTR values, resulting in inflated percentages. Now calculates CTR properly by dividing total clicks by total impressions. Previous Implementation: - CTR was calculated by adding up individual CTR percentages - This resulted in artificially high CTR values - For example: [10%, 15%, 20%] => 45% (incorrect) New Implementation: - CTR is now calculated using (total clicks / total impressions) * 100 - This provides the actual click-through rate across all data - For example: (50 clicks / 1000 impressions) * 100 = 5% (correct) This fix ensures accurate CTR reporting in the analytics dashboard. Changes: - Removed CTR accumulation from reducer - Added proper CTR calculation based on total clicks and impressions - Maintains better statistical accuracy in reporting
|
Great Contribution! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue at #233
The CTR calculation was incorrectly summing up individual CTR values, resulting in inflated percentages. Now calculates CTR properly by dividing total clicks by total impressions.
Previous Implementation:
New Implementation:
This fix ensures accurate CTR reporting in the analytics dashboard.
Changes: