feat(Traefik Proxy): add tracingparameters to helm chart values
#1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkweaver87
reviewed
Dec 9, 2024
added 2 commits
December 9, 2024 09:39
# Conflicts: # traefik/templates/requirements.yaml
mloiseleur
reviewed
Dec 9, 2024
mloiseleur
reviewed
Dec 9, 2024
mloiseleur
reviewed
Dec 9, 2024
darkweaver87
approved these changes
Dec 10, 2024
# Conflicts: # traefik/templates/requirements.yaml
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the option to specify all tracing parameters in the chart values
(sorry i unintentionally closed the first PR)
Motivation
he tracing samplingRate was not exposed in the values, meaning that we have to specify it directly in CLI options if needed.
solves #1269
More
make testand all the tests passed