Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Gateway API): status should not use default service when it's disabled #1300

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(Gateway API): status should not use default service when it's disabled #1300

merged 1 commit into from
Jan 13, 2025

Conversation

mloiseleur
Copy link
Contributor

What does this PR do?

Set empty default on status of kubernetesGateway when service is disabled

Motivation

Fixes #1291

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

darkweaver87
darkweaver87 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mloiseleur mloiseleur force-pushed the fix/gw-status-default branch from 30ecff6 to 6c19ae6 Compare January 13, 2025 13:31
@traefiker traefiker merged commit 1210294 into traefik:master Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkweaver87 darkweaver87 darkweaver87 approved these changes

Assignees
No one assigned
Labels
kind/bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubernetes gateway service probably should not default to the helm chart service if the service is disabled
3 participants
@mloiseleur @darkweaver87 @traefiker