Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev script #454

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Update dev script #454

merged 2 commits into from
Nov 6, 2023

Conversation

adityanaag3
Copy link
Contributor

What does this PR do?

Updates the dev script in package.json to use LWR's built-in dev command. This removes the need to use environment variables to set server mode as 'dev'

What issues does this PR fix or reference?

TCF-036794: The line "dev": "MODE=dev node scripts/start-server.mjs" in package.json only works in mac and linux and not in windows for windows. I had to change it to "dev": "set MODE=dev&& node scripts/start-server.mjs" for it to work.

The PR fulfills these requirements:

[x] Tests for the proposed changes have been added/updated.
[x] Code linting and formatting was performed.

@adityanaag3 adityanaag3 requested a review from a team as a code owner October 30, 2023 10:12
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

⚠️ CodeTour Watch

Changed files with possible CodeTour impact:

  • package.json

Impacted CodeTour files:

  • .tours/using-third-party-javascript-libraries.tour - ⚠️ Missing from PR

Make sure to review CodeTour files and update line numbers accordingly.

@adityanaag3 adityanaag3 requested a review from pozil October 30, 2023 10:16
Copy link
Contributor

@pozil pozil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I updated the clean script to make it cross OX compatible.
Unlike for the E-Bikes Manufacturing demo I went for a simple rimraf module instead of the full shx cross OX shell module since we only use rm -fr here.

@adityanaag3 adityanaag3 merged commit 5079aed into main Nov 6, 2023
4 checks passed
@adityanaag3 adityanaag3 deleted the at/dev-cmd-fix branch November 6, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants