Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual GC triggering + configurable process queue depth #1204

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

trapexit
Copy link
Owner

Yes, these are unrelated changes but somehow ended up being prototyped together and I'm too lazy to separate them.

Yes, these are unrelated changes but somehow ended up being
prototyped together and I'm too lazy to separate them.
@@ -3933,7 +3980,7 @@
fs->op.destroy = NULL;
free(f->fs);
out_free:
free(f);
// free(f);

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.
void
msgbuf_destroy(fuse_msgbuf_t *msgbuf_)
{
// free(msgbuf_->mem);

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.
void
fuse_gc1()
{
syslog_info("running basic garbage collection");

Check warning

Code scanning / CodeQL

Implicit function declaration

Function call implicitly declares 'syslog_info'.
void
fuse_gc()
{
syslog_info("running thorough garbage collection");

Check warning

Code scanning / CodeQL

Implicit function declaration

Function call implicitly declares 'syslog_info'.
{
struct fuse *f = fuse_get_fuse_obj();

syslog_info("invalidating file entries");

Check warning

Code scanning / CodeQL

Implicit function declaration

Function call implicitly declares 'syslog_info'.
if(rv == 0)
return;
if(retriable_receive_error(rv))
continue;

Check warning

Code scanning / CodeQL

Continue statement that does not continue

This 'continue' never re-runs the loop - the [loop condition](1) is always false.
if(rv == 0)
return;
if(retriable_receive_error(rv))
continue;

Check warning

Code scanning / CodeQL

Continue statement that does not continue

This 'continue' never re-runs the loop - the [loop condition](1) is always false.
@@ -200,6 +202,7 @@
_map["threads"] = &fuse_read_thread_count;
_map["read-thread-count"] = &fuse_read_thread_count;
_map["process-thread-count"] = &fuse_process_thread_count;
_map["process-thread-queue-depth"] = &fuse_process_thread_queue_depth;

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory

A stack address which arrived via a [parameter](1) may be assigned to a non-local variable.
@trapexit trapexit merged commit 7cdd12b into master Jun 27, 2023
@trapexit trapexit deleted the gc branch June 27, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant