Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scanning of division vs regex before line ending #246

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Jan 4, 2024

This should improve parsing of expressions with a division (/) operator before a line break. Previously the scanner treated those as the start of a regular expression literal (/..../).

For example:

foo /
5

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@aibaars aibaars merged commit 1ba5af1 into tree-sitter:master Jan 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants