Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create create_release.yml #39

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

looooo
Copy link
Contributor

@looooo looooo commented Feb 21, 2021

just copying some snippets.

@looooo
Copy link
Contributor Author

looooo commented Feb 22, 2021

@trelau any ideas how to test the gh-action instructions?

@trelau
Copy link
Owner

trelau commented Feb 23, 2021

@looooo no. what's the intent of this file/PR?

@looooo
Copy link
Contributor Author

looooo commented Feb 23, 2021

To create a release with the final sources. So we can build smesh from a zipped file.

@trelau
Copy link
Owner

trelau commented Feb 23, 2021

To create a release with the final sources. So we can build smesh from a zipped file.

A few thoughts/questions:

  • Do the final sources need to be prepared only for a release? Or should they be packaged up as an artifact for every Github Action?
  • I "think" it's possible to use CMake to manage submodules and fetch external content. If retrieving the external git repos and checking out the right tag for each submodule was managed by CMake, and therefore part of the build process, would that work instead? Essentially making what's done in prepare.py part of CMake in addition to first downloading the external content.

I could imagine a few approaches:

  • Modify the Github Action workflow to store as an artifact the sources (essentially the src folder after the prepare.py script is run, along with all the other supporting files of course)
  • These artifacts could probably be triggered only for release builds, and I assume we could figure out how to automatically attach the artifacts to the release in Github. Otherwise, at least to start, attaching these artifacts to the release can be done manually.

@trelau
Copy link
Owner

trelau commented Feb 23, 2021

@looooo maybe let's carry on the convo here #38? Then we can circle back on this PR convo when we have a path forward?

@looooo
Copy link
Contributor Author

looooo commented Nov 4, 2021

@trelau this works now on my fork. But I am not sure if uploading works as expected. Currently the upload uses the branch name, see here: https://github.com/looooo/SMESH/releases/tag/create_release

i guess this should only be done for tags / releases.

@basnijholt
Copy link

This would be quite useful, right now the smesh-feedstock relies on cloning the repo which is a very ugly solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants