Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send coins - Advanced address validation #15403

Closed
PeKne opened this issue Nov 15, 2024 · 1 comment · Fixed by #15521
Closed

Send coins - Advanced address validation #15403

PeKne opened this issue Nov 15, 2024 · 1 comment · Fixed by #15521
Assignees
@PeKne
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Milestone
Mobile - Send BTC

Comments

@PeKne
Copy link
Contributor

PeKne commented Nov 15, 2024 •
edited
Loading

The desktop has some more advance send address input validation checks that haven't bee implemented in the mobile yet. See these: deprecated, firmware and uppercase checks.

Also go through this list and check if there is no other validation missing.

Acceptance criteria

All the validation used in desktop apply also for mobile.
@PeKne PeKne added the mobile Suite Lite issues and PRs label Nov 15, 2024
@PeKne PeKne added this to the Mobile - Send BTC milestone Nov 15, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Nov 15, 2024
@PeKne PeKne mentioned this issue Nov 22, 2024
Merged
@PeKne PeKne self-assigned this Nov 22, 2024
@PeKne PeKne moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Nov 22, 2024
@PeKne PeKne moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Mobile Dec 2, 2024
@STew790
Copy link
Contributor

STew790 commented Dec 9, 2024

QA OK
Validations for address are same as on desktop.

Info
24.11.3 f6fa667

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Dec 9, 2024
@STew790 STew790 added the QA OK Issue passed QA without any blocker label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeKne PeKne

Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Suite Mobile
Status: ✅ Approved
Milestone
Mobile - Send BTC
Development

Successfully merging a pull request may close this issue.

feat(suite-native): advanced recipient address validation trezor/trezor-suite
2 participants
@PeKne @STew790