feat(suite-native): advanced recipient address validation #15521
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
yanascz
reviewed
Nov 26, 2024
| isAddressValid(value, networkSymbol) && | ||
| !isAddressDeprecated(value, networkSymbol) && | ||
| !isBech32AddressUppercase(value) && // bech32 addresses are valid as uppercase but are not accepted by Trezor | ||
| !(isTaprootAddress(value, networkSymbol) && isTaprootUnavailable) // bech32m/Taproot addresses are valid but may not be supported by older FW |
There was a problem hiding this comment.
I'm not a fan of ! in front of a complex boolean expression. I'd rename isTaprootUnavailable to isTaprootAvailable and simplify the negation.
There was a problem hiding this comment.
I don't understand. If I will change it to isTaprootAvailable I will have to check for !isTaprootAvailable. I want to return false from this function in case that in the ADDRESS IS TAPROOT and TAPROOT IS UNAVAILABLE.
Feel free to add change suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #15403