Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlap of text in enter xpub via text field #9472

Closed
bosomt opened this issue Sep 18, 2023 · 3 comments · Fixed by #10758 or #11056
Closed

Overlap of text in enter xpub via text field #9472

bosomt opened this issue Sep 18, 2023 · 3 comments · Fixed by #10758 or #11056
Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs

Comments

@bosomt
Copy link
Contributor

bosomt commented Sep 18, 2023

Describe the bug
See screenshot.
When you enter xpub manually placeholder text is not deleted and both text overlaps.

Info:

How to reproduce
Steps to reproduce the behavior:

Screenshots
Screenshot 2023-09-18 at 15 55 50
@bosomt bosomt added bug Something isn't working as expected mobile Suite Lite issues and PRs labels Sep 18, 2023
@juriczech juriczech moved this to 🏃‍♀️ In progress in Suite Mobile Jan 18, 2024
@juriczech juriczech self-assigned this Jan 18, 2024
@juriczech juriczech moved this from 🏃‍♀️ In progress to 🎯 To do in Suite Mobile Jan 19, 2024
@juriczech juriczech removed their assignment Jan 19, 2024
@PeKne PeKne self-assigned this Jan 23, 2024
@PeKne PeKne moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Jan 23, 2024
@PeKne PeKne mentioned this issue Jan 23, 2024
Merged
@PeKne PeKne moved this from 🏃‍♀️ In progress to 🔎 Needs review in Suite Mobile Jan 23, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Suite Mobile Jan 24, 2024
@bosomt
Copy link
Contributor Author

bosomt commented Jan 26, 2024

QA NOK

when you enter xpub manually it does not overlap anymore
but when you scan it and you go back due to already imported it overlaps

how to replicate:

  • import asset
  • import again
  • navigate back
  • observe overlap

24.2.0 (709) c12a2a8 - [develop] - wip commit to get the develop build

telegram-cloud-photo-size-4-5879572193002767052-y

telegram-cloud-document-4-5879572192546529155.1.mov

@bosomt bosomt moved this from 🤝 Needs QA to 🎯 To do in Suite Mobile Jan 26, 2024
@PeKne
Copy link
Contributor

PeKne commented Jan 26, 2024

Good catch 😎

@matejkriz matejkriz moved this from 🎯 To do to 🤝 Needs QA in Suite Mobile Feb 1, 2024
@matejkriz matejkriz moved this from 🤝 Needs QA to 🎯 To do in Suite Mobile Feb 1, 2024
@PeKne PeKne removed their assignment Feb 5, 2024
PeKne added a commit that referenced this issue Feb 6, 2024
@PeKne
fix(suite-native): input top padding
bdbc5ed 
- fixes conditonal top padding, the padding should be always the same independent of `isFocused` state

Closes #9472
@PeKne PeKne mentioned this issue Feb 6, 2024
Merged
trezor-ci pushed a commit that referenced this issue Feb 7, 2024
@PeKne
fix(suite-native): input top padding
7c4e8d7 
- fixes conditonal top padding, the padding should be always the same independent of `isFocused` state

Closes #9472
PeKne added a commit that referenced this issue Feb 8, 2024
@PeKne
fix(suite-native): input top padding (#11056)
5e5a882 
- fixes conditonal top padding, the padding should be always the same independent of `isFocused` state

Closes #9472
@matejkriz matejkriz moved this from 🎯 To do to 🤝 Needs QA in Suite Mobile Feb 12, 2024
@bosomt
Copy link
Contributor Author

bosomt commented Feb 22, 2024

QA OK

Android 14 - Nothing Phone 1
24.3.1 (24) dev version 6e9d8d6

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
3 participants
@PeKne @bosomt @juriczech