Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(suite): UI variants unification #11280

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

jvaclavik
Copy link
Contributor

Description

Related Issue

Resolve #10818

Screenshots:

@jvaclavik jvaclavik force-pushed the ui-variant-refactoring branch 2 times, most recently from d61e457 to 9804fa0 Compare February 23, 2024 15:35
@jvaclavik jvaclavik marked this pull request as ready for review February 23, 2024 15:53
Copy link
Contributor

@peter-sanderson peter-sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just please fix the accidentally committed sub-moduls and lets replace switches for strict type mapping with Record s

@jvaclavik jvaclavik force-pushed the ui-variant-refactoring branch from 8ab55e8 to da82841 Compare February 27, 2024 07:18
Copy link
Contributor

@peter-sanderson peter-sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🚢 🇮🇹

@jvaclavik jvaclavik merged commit a20b6c3 into develop Feb 27, 2024
6 of 7 checks passed
@jvaclavik jvaclavik deleted the ui-variant-refactoring branch February 27, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Extract variant types from one place
2 participants