feat(suite-native): token definitions redux logic #11318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytick
requested changes
Feb 23, 2024
suite-native/module-accounts-import/src/components/AccountImportSummaryForm.tsx
Show resolved
Hide resolved
suite-common/wallet-core/src/token-definitions/tokenDefinitionsSelectors.ts
Show resolved
Hide resolved
suite-native/token-definitions/src/tokenDefinitionsMiddleware.ts
Outdated
Show resolved
Hide resolved
suite-native/module-accounts-import/src/screens/AccountImportLoadingScreen.tsx
Show resolved
Hide resolved
suite-native/module-accounts-import/src/screens/AccountImportLoadingScreen.tsx
Show resolved
Hide resolved
Nodonisko
reviewed
Feb 25, 2024
| action.payload.tokens?.forEach(token => { | ||
| const contractAddress = token.contract; | ||
|
|
||
| const tokenDefinition = selectSpecificTokenDefinition( |
There was a problem hiding this comment.
What about creating selector selectShouldFetchTokenDefinion?
juriczech
reviewed
Feb 26, 2024
juriczech
reviewed
Feb 26, 2024
suite-native/token-definitions/src/tokenDefinitionsMiddleware.ts
Outdated
Show resolved
Hide resolved
suite-native/token-definitions/src/tokenDefinitionsMiddleware.ts
Outdated
Show resolved
Hide resolved
PeKne
force-pushed
the
feat/suite-native-token-definitions
branch
from
6cf5d4c to
cd98e01
Compare
juriczech
approved these changes
Feb 26, 2024
Nodonisko
approved these changes
Feb 26, 2024
PeKne
force-pushed
the
feat/suite-native-token-definitions
branch
from
a017a0f to
ed01969
Compare
juriczech
approved these changes
Feb 27, 2024
|
/rebase |
trezor-ci
force-pushed
the
feat/suite-native-token-definitions
branch
from
ed01969 to
7b523ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Closes #8434
Closes #11308
Screenshots:
Token definitions are correctly handled in the redux state, app works as expected:
