Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(suite-native): unmemoized selectors #15562

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(suite-native): unmemoized selectors #15562

wants to merge 1 commit into from
+54 −45

Conversation

PeKne
Copy link
Contributor

@PeKne PeKne commented Nov 25, 2024

Related Issue

Resolve #15524

@PeKne PeKne added the mobile Suite Lite issues and PRs label Nov 25, 2024
@PeKne PeKne requested a review from a team as a code owner November 25, 2024 15:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 11
  • More info

Learn more about 𝝠 Expo Github Action

@Nodonisko
Copy link
Contributor

You may be able to remove useDeepEqualSelectors but please test it first

yanascz
yanascz approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@yanascz yanascz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more warnings in the log! 🥳

@PeKne
Copy link
Contributor Author

PeKne commented Nov 26, 2024 •
edited
Loading

@Nodonisko, please check the commit e541b3d where useSelectorDeepComparison is removed.

@PeKne PeKne force-pushed the fix/native/memoized-selectors branch 2 times, most recently from e541b3d to b79c1ec Compare November 26, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanascz yanascz yanascz approved these changes

@Nodonisko Nodonisko Nodonisko approved these changes

Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix console warning for selectors
3 participants
@PeKne @Nodonisko @yanascz