Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python -m pip instead #31

Merged
merged 1 commit into from
May 10, 2018
Merged

Use python -m pip instead #31

merged 1 commit into from
May 10, 2018

Conversation

stephensolis
Copy link
Contributor

@stephensolis stephensolis commented May 10, 2018

It seems in v10, pip has moved the location of the main package, see pypa/pip#5240 -- there's really no need to update pip here anyway
Reading the linked issue (pypa/pip#5221 (comment)), actually it seems using python -m pip is a better solution for this.

@amccannv this should fix the issue you were seeing

@stephensolis stephensolis requested review from 2J, bvisch and amccannv May 10, 2018 19:27
@codecov
Copy link

codecov bot commented May 10, 2018

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   73.38%   73.38%           
=======================================
  Files           5        5           
  Lines         124      124           
=======================================
  Hits           91       91           
  Misses         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dde0a0...07ddaea. Read the comment docs.

@stephensolis stephensolis changed the title Don't update pip Use python -m pip instead May 10, 2018
Copy link

@amccannv amccannv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thanks!

@stephensolis stephensolis merged commit 571d923 into master May 10, 2018
@stephensolis stephensolis deleted the no-update-pip branch May 10, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants