Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update partial_io to version 0.5.4 #108

Merged

Conversation

folkertdev
Copy link
Collaborator

This removes the double dependency on 2 versions of quickcheck, and updates the version of rand that can be used. Only newer versions of rand work with the wasm targets.

in combination with #89 and by using our pure rust fully compatible implementation of bzip2 https://github.com/trifectatechfoundation/libbzip2-rs we can just run the tests with wasmtime

> cargo test --no-default-features --features="libbzip2-rs-sys" --target wasm32-wasip1
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.01s
     Running unittests src/lib.rs (target/wasm32-wasip1/debug/deps/bzip2-4323b5447be16c4a.wasm)

running 15 tests
test bufread::tests::bug_61 ... ok
test read::tests::empty ... ok
test read::tests::multistream_read_till_eof ... ok
test read::tests::qc ... ok
test read::tests::qc_partial ... ok
test read::tests::self_terminating ... ok
test read::tests::smoke ... ok
test read::tests::smoke2 ... ok
test read::tests::smoke3 ... ok
test read::tests::zero_length_read_at_eof ... ok
test read::tests::zero_length_read_with_data ... ok
test write::tests::qc ... ok
test write::tests::qc_partial ... ok
test write::tests::smoke ... ok
test write::tests::write_empty ... ok

The msrv of the latest version is 1.56, which is over 3 years old now. Also, the potential msrv bump is just for running the tests, so I don't think it's a problem.

@alexcrichton alexcrichton merged commit 9d4ad68 into trifectatechfoundation:master Dec 3, 2024
9 checks passed
@alexcrichton
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants