Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Question #3

Closed
keano12 opened this issue Jun 5, 2014 · 8 comments
Closed

Grid Question #3

keano12 opened this issue Jun 5, 2014 · 8 comments

Comments

@keano12
Copy link

keano12 commented Jun 5, 2014

Can someone tell me which is wrong here and why. One of the psd's my friend made for bootstrap 3 the other is the ps-bootstrap3-grid-generator.

https://www.dropbox.com/s/a5jzhzjsjfnwkaw/grids.zip

Thank you

@toovy
Copy link
Member

toovy commented Jun 5, 2014

I think the generator is correct. I think the documentation of bootstrap is incorrect. It says the column width is 95px, if you subtract the gutter width of 30px you've got 65px.

The truth seems to be that you've got 1170px that are splitted into 24*15px gutter and (n)px columns. That means for the columns there is a space of 1170px - 24 * 15px = 810px left. 810px / 12 columns = 67.5px per column. A look at the chrome inspector reflects this mathematical thesis.

The grid of your friend is 1170px wide. Then there is a gutter of 15px before the first columns gutter begins, so he got a space of 30px which should be 15px. I've created a real grid with HTML and made a screenshot:

bootstrap-grid

If you look at my screenshots below, you can see that the generator script matches the real web-base-grid.

bildschirmfoto 2014-06-05 um 17 21 44
bildschirmfoto 2014-06-05 um 17 21 39

Hope I could help.

@toovy toovy closed this as completed Jun 5, 2014
@toovy
Copy link
Member

toovy commented Jun 5, 2014

P.S.: Here the evidence that I'm correct twbs/bootstrap#12808

@keano12
Copy link
Author

keano12 commented Jun 12, 2014

Hi can you help explain to me how to make this design fit into the bootstrap 1170. Problem is we need 15px more white space on each side to the frame. Any help appreciated

Sean

@toovy
Copy link
Member

toovy commented Jun 13, 2014

We'll it is possible to customize the grid on http://getbootstrap.com/customize/ , look out for the "Grid System" and "Container sizes" settings. If you need a smaller grid you probably could just change
@container-large-desktop from
((1140px + @grid-gutter-width))
to
((1110px + @grid-gutter-width))

@keano12
Copy link
Author

keano12 commented Jul 1, 2014

Hi is the grid issue fixed? in 3.2 release of Bootstrap? The grid not being perfect on the 1170 one?

Thank you!

On Friday, June 13, 2014 5:13 AM, toovy [email protected] wrote:

We'll it is possible to customize the grid on http://getbootstrap.com/customize/ , look out for the "Grid System" and "Container sizes" settings. If you need a smaller grid you probably could just change
@container-large-desktop from
((1140px + @grid-gutter-width))
to
((1110px + @grid-gutter-width))

Reply to this email directly or view it on GitHub.

@keano12
Copy link
Author

keano12 commented Jul 1, 2014

Hi thanks for feedback in says in 3.2 #12808: Correct grid column values listed in Grid Options. it has been corrected. So what would the fixed column width be now?

@toovy
Copy link
Member

toovy commented Jul 2, 2014

Please see http://getbootstrap.com/css/#grid

@keano12
Copy link
Author

keano12 commented Jul 2, 2014

Ahhh thanks

Sent from my iPhone

On Jul 1, 2014, at 9:46 PM, toovy [email protected] wrote:

Please see http://getbootstrap.com/css/#grid


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants