Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation info: column width #12808

Closed
minimit opened this issue Feb 21, 2014 · 6 comments
Closed

Wrong documentation info: column width #12808

minimit opened this issue Feb 21, 2014 · 6 comments
Milestone

Comments

@minimit
Copy link

minimit commented Feb 21, 2014

http://getbootstrap.com/css/#grid-options
The column widths are wrong:

It says:
Small devices Tablets (≥768px): 60px
Medium devices Desktops (≥992px): 78px
Large devices Desktops (≥1200px): 95px

You can check by inspecting bootstrap columns on the browsers, and they are impossible by math, for example: 1170px/12 = 97.5px (columns are 97-98px)

The right ones are this:
Small devices Tablets (≥768px): 62-63px
Medium devices Desktops (≥992px): 80-81px
Large devices Desktops (≥1200px): 97-98px

Check out the psd templates I've done, they are with the right values http://www.minimit.com/articles/tips-resources/bootstrap-3-grid-psd-templates

@keano12
Copy link

keano12 commented Jul 1, 2014

Is this fixed in 3.2? Does the grid at 1170 have a fixed column size?
Thanks

@cvrebert
Copy link
Collaborator

cvrebert commented Jul 1, 2014

@keano12 The documentation was tweaked in 3.2. See the above commit.

@keano12
Copy link

keano12 commented Jul 1, 2014

So before it was Large devices Desktops (≥1200px): 97-98px is it now a fixed number? I am trying to make a PS template for the 3.2 version. My designers were always pissed because the grid was off here and there 1px LOL.

@minimit
Copy link
Author

minimit commented Jul 1, 2014

Hey keano

97-98px are calculated by a percent on the container width, so when you have 12 columns on the 1200px+ size, you have columns with 97-98px.

See the response when I noted this issue of having inconsistent column width: #10524

@mdo
Copy link
Member

mdo commented Jul 1, 2014

1170px / 12 columns = 97.5px.

The grid has always used percentages as their widths. We'll have more precise computed widths in v4 when we can revisit the container widths.

@keano12
Copy link

keano12 commented Jul 1, 2014

Thank you. 

On Tuesday, July 1, 2014 3:38 PM, Mark Otto [email protected] wrote:

1170px / 12 columns = 97.5px.
The grid has always used percentages as their widths. We'll have more precise computed widths in v4 when we can revisit the container widths.

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants