Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abstraction for real/target object store #20

Closed
Randgalt opened this issue May 23, 2024 · 1 comment · Fixed by #36
Closed

Add abstraction for real/target object store #20

Randgalt opened this issue May 23, 2024 · 1 comment · Fixed by #36
Assignees
@Randgalt

Comments

@Randgalt
Copy link
Member

Currently, the target/real object store is hard-coded to AWS S3. The proxy should be able to target other object stores like Minio, etc. Initially, we can assume all object stores are S3-compatible so the only differentiator is the URL to proxy to.

For the future, do we want to consider non-S3 object stores? That seems overkill to me. wdyt? cc @vagaerg, @dain, @mosiac1
@Randgalt Randgalt mentioned this issue May 23, 2024
Closed
Randgalt added a commit that referenced this issue May 28, 2024
@Randgalt
Replace endpoint builder with ObjectStore abstraction
01214a2 
`ObjectStore` is a better abstraction and will allow support for
various S3-compatible object stores.

Closes #20
@Randgalt Randgalt mentioned this issue May 28, 2024
Merged
@vagaerg
Copy link
Member

vagaerg commented May 28, 2024

I don't think non-S3 object stores (or non S3-like) are necessarily overkill as some other projects like https://github.com/gaul/s3proxy implement such functionality, with the goal of exposing an S3-like API for non-S3 systems.

That said, we can probably defer this for later?

@Randgalt Randgalt self-assigned this May 28, 2024
@vagaerg vagaerg mentioned this issue May 28, 2024
Open
Randgalt added a commit that referenced this issue May 28, 2024
@Randgalt
Replace endpoint builder with ObjectStore abstraction
3752f3a 
`ObjectStore` is a better abstraction and will allow support for
various S3-compatible object stores.

Closes #20
Randgalt added a commit that referenced this issue May 28, 2024
@Randgalt
Replace endpoint builder with ObjectStore abstraction
223b0c3 
`ObjectStore` is a better abstraction and will allow support for
various S3-compatible object stores.

Closes #20
Randgalt added a commit that referenced this issue May 28, 2024
@Randgalt
Replace endpoint builder with ObjectStore abstraction
be5eae1 
`ObjectStore` is a better abstraction and will allow support for
various S3-compatible object stores.

Closes #20
Randgalt added a commit that referenced this issue May 28, 2024
@Randgalt
Replace endpoint builder with remote facade abstraction
ee6e3d4 
`RemoteS3Facade` is a better abstraction and will allow support for
various S3-compatible object stores.

Closes #20
Randgalt added a commit that referenced this issue May 28, 2024
@Randgalt
Replace endpoint builder with remote facade abstraction
c9a1e83 
`RemoteS3Facade` is a better abstraction and will allow support for
various S3-compatible object stores.

Closes #20
Randgalt added a commit that referenced this issue May 28, 2024
@Randgalt
Replace endpoint builder with remote facade abstraction
f71d1d2 
`RemoteS3Facade` is a better abstraction and will allow support for
various S3-compatible object stores.

Closes #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Randgalt Randgalt

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace endpoint builder with ObjectStore abstraction trinodb/aws-proxy
2 participants
@Randgalt @vagaerg